• Type: Improvement
• Resolution: Fixed
• Priority: Major
• Fix Version/s: 4.5.0
• Affects Version/s: 4.3.0
• Component/s: None
• Labels:

  None

1. 

   image-2021-06-29-14-53-03-727.png

   128 kB

   29/Jun/21 14:53

[RUNTIME-3297] Review SendMailHelper API

Collapse comment: Simon Prieul (Inactive) added a comment - 18/Nov/19 10:40

Simon Prieul (Inactive) added a comment - 18/Nov/19 10:40

For instance

 

SendMailHelper has just one method

MailFactory newMailFactory();

 

class MailFactory has many (15 I think) methods

MailFactory withSubject(String subject)

MailFactory withRecipient(String recipient)

MailFactory withBody(String body)

etc.

and a method to build it into a mail

Mail build();

which can throw IllegalStateException if the recipient was not set for instance, etc.

Mail has 2 methods

void sendAsHtml();

void sendAsText;

Expand comment: Simon Prieul (Inactive) added a comment - 18/Nov/19 10:40

Simon Prieul (Inactive) added a comment - 18/Nov/19 10:40 For instance   SendMailHelper has just one method MailFactory newMailFactory();   class MailFactory has many (15 I think) methods MailFactory withSubject( String subject) MailFactory withRecipient( String recipient) MailFactory withBody( String body) etc. and a method to build it into a mail Mail build(); which can throw IllegalStateException if the recipient was not set for instance, etc. Mail has 2 methods void sendAsHtml(); void sendAsText;